Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update autorest emitter to 0.42.1 #29114

Merged
merged 2 commits into from
May 15, 2024
Merged

Update autorest emitter to 0.42.1 #29114

merged 2 commits into from
May 15, 2024

Conversation

timotheeguerin
Copy link
Member

No description provided.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 15, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 15, 2024 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 15, 2024 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

@mikeharder
Copy link
Member

/azp run TypeSpec Requirement

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeharder
Copy link
Member

@timotheeguerin: I will probably need to force-merge this due to Azure/azure-sdk-tools#7657

@timotheeguerin
Copy link
Member Author

timotheeguerin commented May 15, 2024 •
edited
Loading

@timotheeguerin: I will probably need to force-merge this due to Azure/azure-sdk-tools#7657

Ran pwsh ./eng/scripts/TypeSpec-Validation.ps1 -CheckAll and doesn't seem to be any diff so wouldn't expect it to fail here, so should be good I think when TypeSpec validation - all pass

@timotheeguerin timotheeguerin merged commit 0a8300f into main May 15, 2024
39 of 40 checks passed
@timotheeguerin timotheeguerin deleted the update/autorest-0.42.1 branch May 15, 2024 20:22
@konrad-jamrozik
Copy link

konrad-jamrozik commented May 16, 2024 •
edited
Loading

@mikeharder additions of PipelineBotTrigger are manifestation of the solution to this issue working:

Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
@timotheeguerin @Francisco-Gamino
Update autorest emitter to 0.42.1 (Azure#29114)
b81a63b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeharder mikeharder mikeharder approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

Assignees
No one assigned
Labels
PipelineBotTrigger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timotheeguerin @mikeharder @konrad-jamrozik